netdev - Re: [ethtool, 3/3] ethtool: correct VF index values for the ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180227193202.GD25950@tuxdriver.com>
Date:   Tue, 27 Feb 2018 14:32:02 -0500
From:   "John W. Linville" <linville@...driver.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     linville@...hat.com, Jacob Keller <jacob.e.keller@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        jogreene@...hat.com
Subject: Re: [ethtool, 3/3] ethtool: correct VF index values for the
 ring_cookie parameter

On Mon, Feb 26, 2018 at 10:49:56AM -0800, Jeff Kirsher wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> Instead of relying on the input being offset by 1, instead adjust the
> "vf" input value by 1 so that it correctly targets the VF the user
> expects. Additionally, update the displayed output to show the correct
> VF number.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

LGTM -- queued for ethtool-4.16...

Thanks!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.