netdev - Re: [PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e416909-21bd-92f6-816d-695d8eaa16aa@cumulusnetworks.com>
Date:   Wed, 28 Feb 2018 00:14:57 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Yuval Mintz <yuvalm@...lanox.com>, netdev@...r.kernel.org
Cc:     mlxsw@...lanox.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new
 mr_table

On 27/02/18 20:58, Yuval Mintz wrote:
> Now that both ipmr and ip6mr are using the same mr_table structure,
> we can have a common function to allocate & initialize a new instance.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  include/linux/mroute_base.h | 17 +++++++++++++++++
>  net/ipv4/ipmr.c             | 27 ++++++++++-----------------
>  net/ipv4/ipmr_base.c        | 27 +++++++++++++++++++++++++++
>  net/ipv6/ip6mr.c            | 30 ++++++++++--------------------
>  4 files changed, 64 insertions(+), 37 deletions(-)
> 

I don't like the function definition broken with the name and type on different rows, but
I guess it's a personal preference, the patch looks okay.

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>