netdev - Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABB6175-4FC3-4742-9C54-FCDEE3E5A608@intel.com>
Date:   Tue, 27 Feb 2018 22:45:19 +0000
From:   "Rustad, Mark D" <mark.d.rustad@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "Daly, Dan" <dan.daly@...el.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "MRustad@...il.com" <MRustad@...il.com>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "mst@...hat.com" <mst@...hat.com>
Subject: Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

> On Feb 27, 2018, at 7:35 AM, David Miller <davem@...emloft.net> wrote:
> 
> I don't like these helpers on many different levels.

<snip much embarrassment>

> So kill off pci_sriov_enable() helper completely, it is unnecessary,
> and rename the disable helper so that it says something meaningful to
> the reader.

Yes. Once pointed out, I completely agree with your comments and wish that I had seen those things myself.

> Thanks.

V3 was junk, but your comments apply to V4 as well, so please ignore it.

Thank you for your valuable review.

-- 
Mark Rustad, Networking Division, Intel Corporation