netdev - Re: [PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24c22a91-4f16-b9be-7cac-28087c6b73a1@cumulusnetworks.com>
Date:   Wed, 28 Feb 2018 00:51:50 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Yuval Mintz <yuvalm@...lanox.com>, netdev@...r.kernel.org
Cc:     mlxsw@...lanox.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

On 27/02/18 20:58, Yuval Mintz wrote:
> The various MFC entries are being held in the same kind of mr_tables
> for both ipmr and ip6mr, and their traversal logic is identical.
> Also, with the exception of the addresses [and other small tidbits]
> the major bulk of the nla setting is identical.
> 
> Unite as much of the dumping as possible between the two.
> Notice this requires creating an mr_table iterator for each, as the
> for-each preprocessor macro can't be used by the common logic.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  include/linux/mroute_base.h |  29 ++++++++
>  net/ipv4/ipmr.c             | 161 +++++++++++---------------------------------
>  net/ipv4/ipmr_base.c        | 123 +++++++++++++++++++++++++++++++++
>  net/ipv6/ip6mr.c            | 156 +++++++++++-------------------------------
>  4 files changed, 230 insertions(+), 239 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>