netdev - Re: [PATCH v2 net] net: phy: Restore phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Feb 2018 19:40:40 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
CC:     hkallweit1@...il.com, netdev <netdev@...r.kernel.org>,
        linyunsheng@...wei.com
Subject: Re: [PATCH v2 net] net: phy: Restore phy_resume() locking assumption

On February 26, 2018 4:56:06 PM PST, Andrew Lunn <andrew@...n.ch> wrote:
>commit f5e64032a799 ("net: phy: fix resume handling") changes the
>locking semantics for phy_resume() such that the caller now needs to
>hold the phy mutex. Not all call sites were adopted to this new
>semantic, resulting in warnings from the added
>WARN_ON(!mutex_is_locked(&phydev->lock)).  Rather than change the
>semantics, add a __phy_resume() and restore the old behavior of
>phy_resume().
>
>Reported-by: Heiner Kallweit <hkallweit1@...il.com>
>Fixes: f5e64032a799 ("net: phy: fix resume handling")
>Signed-off-by: Andrew Lunn <andrew@...n.ch>
>---
>v2: Fix type in phy_resume() calling itself
>---

This version looks good thanks for taking care of that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

-- 
Florian