netdev - Re: [PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfb2b8be-f7ec-84e2-5b77-b06f90105dc9@cumulusnetworks.com>
Date:   Wed, 28 Feb 2018 15:09:40 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     dsa@...ulusnetworks.com, idosch@...lanox.com, pabeni@...hat.com
Subject: Re: [PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport,
 dport and ip proto

On 28/02/18 05:52, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> support to match on src port, dst port and ip protocol.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  net/ipv4/fib_rules.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
> index 35d646a..16083b8 100644
> --- a/net/ipv4/fib_rules.c
> +++ b/net/ipv4/fib_rules.c
> @@ -182,6 +182,17 @@ static int fib4_rule_match(struct fib_rule *rule, struct flowi *fl, int flags)
>  	if (r->tos && (r->tos != fl4->flowi4_tos))
>  		return 0;
>  
> +	if (rule->ip_proto && (rule->ip_proto != fl4->flowi4_proto))
> +		return 0;
> +
> +	if (fib_rule_port_range_set(&rule->sport_range) &&
> +	    !fib_rule_port_inrange(&rule->sport_range, fl4->fl4_sport))
> +		return 0;
> +
> +	if (fib_rule_port_range_set(&rule->dport_range) &&
> +	    !fib_rule_port_inrange(&rule->dport_range, fl4->fl4_dport))
> +		return 0;
> +
>  	return 1;
>  }
>  
> 

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>