netdev - Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79cf073e-6b72-f139-46d3-79322d16209f@oracle.com>
Date:   Wed, 28 Feb 2018 10:21:07 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Jason Andryuk <jandryuk@...il.com>, xen-devel@...ts.xenproject.org,
        netdev@...r.kernel.org
Cc:     Eduardo Otubo <otubo@...hat.com>, Juergen Gross <jgross@...e.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen-netfront: Fix hang on device removal

On 02/28/2018 07:23 AM, Jason Andryuk wrote:
> A toolstack may delete the vif frontend and backend xenstore entries
> while xen-netfront is in the removal code path.  In that case, the
> checks for xenbus_read_driver_state would return XenbusStateUnknown, and
> xennet_remove would hang indefinitely.  This hang prevents system
> shutdown.
>
> xennet_remove must be able to handle XenbusStateUnknown, and
> netback_changed must also wake up the wake_queue for that state as well.
>
> Fixes: 5b5971df3bc2 ("xen-netfront: remove warning when unloading module")
>
> Signed-off-by: Jason Andryuk <jandryuk@...il.com>
> Cc: Eduardo Otubo <otubo@...hat.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>