netdev - Re: [PATCH net] gianfar: Fix Rx byte accounting for ndev stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180228.105950.736675042430460251.davem@davemloft.net>
Date:   Wed, 28 Feb 2018 10:59:50 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org, aspencer@...cex.com
Subject: Re: [PATCH net] gianfar: Fix Rx byte accounting for ndev stats

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Tue, 27 Feb 2018 17:33:10 +0200

> Don't include in the Rx bytecount of the packet sent up the stack:
> the FCB (frame control block), and the padding bytes inserted by
> the controller into the frame payload, nor the FCS. All these are
> being pulled out of the skb by gfar_process_frame().
> This issue is old, likely from the driver's beginnings, however
> it was amplified by recent:
> commit d903ec77118c ("gianfar: simplify FCS handling and fix memory leak")
> which basically added the FCS to the Rx bytecount, and so brought
> this to my attention.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied, thank you.