netdev - Re: [PATCH net] tcp: purge write queue upon RST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKjToT20XZ2YbDSrXdLkP=SEj6K14CRmw=g-nLjncCh7Q@mail.gmail.com>
Date:   Wed, 28 Feb 2018 08:46:09 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     Soheil Hassas Yeganeh <soheil.kdev@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH net] tcp: purge write queue upon RST

On Wed, Feb 28, 2018 at 8:42 AM, David Miller <davem@...emloft.net> wrote:
> From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
> Date: Tue, 27 Feb 2018 18:32:18 -0500
>
>> From: Soheil Hassas Yeganeh <soheil@...gle.com>
>>
>> When the connection is reset, there is no point in
>> keeping the packets on the write queue until the connection
>> is closed.
>>
>> RFC 793 (page 70) and RFC 793-bis (page 64) both suggest
>> purging the write queue upon RST:
>> https://tools.ietf.org/html/draft-ietf-tcpm-rfc793bis-07
>>
>> Moreover, this is essential for a correct MSG_ZEROCOPY
>> implementation, because userspace cannot call close(fd)
>> before receiving zerocopy signals even when the connection
>> is reset.
>>
>> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
>> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
>> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
>> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
>
> This is one of those "yeah, why have we been doing this all of
> this time?" kind of situation.
>
> Let's hope there isn't some subtle side effect, but indeed this
> current behavior is broken for MSG_ZEROCOPY.
>

One of the effect is that for very large queues (more than 100 MB), queue purge
might take a lot of time, in BH context (while handling one RST)

But even before the patch, this could also happen from BH context anyway.

We might use work queue (s) in the future to handle the purge in the
background in process context.
But really this is not urgent.

> Applied and queued up for -stable, thanks!

Thanks David.