netdev - Re: [PATCH net,v3] vrf: check forwarding on the original netdevice when generating ICMP dest unreachable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01df17c0-34e4-7e40-746d-0408ff1f3d58@gmail.com>
Date:   Wed, 28 Feb 2018 11:19:18 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Suryaputra <ssuryaextr@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net,v3] vrf: check forwarding on the original netdevice
 when generating ICMP dest unreachable

On 2/28/18 10:20 AM, Stephen Suryaputra wrote:
> When ip_error() is called the device is the l3mdev master instead of the
> original device. So the forwarding check should be on the original one.
> 
> Changes from v2:
> - Handle the original device disappearing (per David Ahern)
> - Minimize the change in code order
> 
> Changes from v1:
> - Only need to reset the device on which __in_dev_get_rcu() is done (per
>   David Ahern).
> 
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> ---
>  net/ipv4/route.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 

Acked-by: David Ahern <dsahern@...il.com>