netdev - Re: [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d58d222-9b7c-1775-574f-b171d1daa5a6@cumulusnetworks.com>
Date:   Wed, 28 Feb 2018 23:56:34 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Yuval Mintz <yuvalm@...lanox.com>, netdev@...r.kernel.org,
        davem@...veloft.net
Cc:     mlxsw@...lanox.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching
 in MFC cache

On 28/02/18 23:29, Yuval Mintz wrote:
> ipmr and ip6mr utilize the exact same methods for searching the
> hashed resolved connections, difference being only in the construction
> of the hash comparison key.
> 
> In order to unite the flow, introduce an mr_table operation set that
> would contain the protocol specific information required for common
> flows, in this case - the hash parameters and a comparison key
> representing a (*,*) route.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  include/linux/mroute_base.h | 52 +++++++++++++++++++++++++++++--
>  net/ipv4/ipmr.c             | 71 ++++++++++---------------------------------
>  net/ipv4/ipmr_base.c        | 54 +++++++++++++++++++++++++++++++--
>  net/ipv6/ip6mr.c            | 74 +++++++++++----------------------------------
>  4 files changed, 134 insertions(+), 117 deletions(-)
> 

Thanks!

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>