netdev - Re: [PATCH ipsec-next] esp: check the NETIF_F_HW_ESP_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 09:41:27 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Shannon Nelson <shannon.nelson@...cle.com>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec-next] esp: check the NETIF_F_HW_ESP_TX_CSUM bit
 before segmenting

On Mon, Feb 26, 2018 at 02:28:19PM -0800, Shannon Nelson wrote:
> If I understand correctly, we should not be asking for a
> checksum offload on an ipsec packet if the netdev isn't
> advertising NETIF_F_HW_ESP_TX_CSUM.  In that case, we should
> clear the NETIF_F_CSUM_MASK bits.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@...cle.com>

Patch applied, thanks Shannon!