netdev - Re: [PATCH net-next 1/2] mac80211_hwsim: Make hwsim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a826ac0-1354-567b-ec4c-ac8511bf89f6@uni-rostock.de>
Date:   Thu, 1 Mar 2018 18:22:26 +0100
From:   Benjamin Beichler <Benjamin.Beichler@...-rostock.de>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>, <davem@...emloft.net>,
        <johannes@...solutions.net>, <kvalo@...eaurora.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] mac80211_hwsim: Make hwsim_netgroup IDA

Am 01.03.2018 um 12:30 schrieb Kirill Tkhai:

> Out of bounds of this patch, just as a report to wireless subsystem
> maintainer, destroy_radio() increaments hwsim_radios_generation
> without hwsim_radio_lock, so this may need one more patch to fix.
>
The lock is here implicit, because the value only could change at init
(where netlink callbacks are deactivated and always happens sequential)
or in netlink callbacks. The only reader of this variable is the dump
callback, and the only other writers are also netlink callbacks and
because they are implicitly not parallel (because the parallel flag is
not set), there could be no race condition. Maybe this should be
documented somehow, especially if somebody got the idea to allow
parallel callbacks :-)

-- 
M.Sc. Benjamin Beichler

Universität Rostock, Fakultät für Informatik und Elektrotechnik
Institut für Angewandte Mikroelektronik und Datentechnik

University of Rostock, Department of CS and EE
Institute of Applied Microelectronics and CE

Richard-Wagner-Straße 31
18119 Rostock
Deutschland/Germany

phone: +49 (0) 381 498 - 7278
email: Benjamin.Beichler@...-rostock.de
www: http://www.imd.uni-rostock.de/