netdev - Re: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet difference in multipath tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180301193736.GC4839@splinter>
Date:   Thu, 1 Mar 2018 21:37:36 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        idosch@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH net-next 3/5] selftests: forwarding: Handle 0 for packet
 difference in multipath tests

On Thu, Mar 01, 2018 at 11:09:45AM -0800, David Ahern wrote:
> If the packet stats have a difference of 0, the test output shows:
> INFO: Expected ratio 2.00 Measured ratio
> Runtime error (func=(main), adr=9): Divide by zero
> (standard_in) 2: syntax error
> (standard_in) 1: syntax error
> ./router_multipath.sh: line 187: test: : integer expression expected
> TEST: Multipath                                                     [FAIL]
> 	Too large discrepancy between expected and measured ratios
> 
> Handle the 0 and display a cleaner message:
> INFO: Running IPv6 multipath tests
> TEST: Multipath                                                     [FAIL]
> 	Packet difference is 0
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>

Thanks!