netdev - Re: help on iproute2 hangs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SYvRwMkqc85Q5K8NfHxhAxoq4GBU-J1ErOsP3tqKB7BVA@mail.gmail.com>
Date:   Thu, 1 Mar 2018 14:24:19 -0800
From:   William Tu <u9012063@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        chrism@...lanox.com
Subject: Re: help on iproute2 hangs

>
> I still can not reproduce the hang, but try this and see if it fixes
> your problem (whitespace damaged on paste):
>
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 7ca47b22581a..9d692afbc740 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -670,8 +672,9 @@ static int __rtnl_talk_iov(struct rtnl_handle *rtnl,
> struct iovec *iov,
>                                                 free(buf);
>                                         if (h->nlmsg_seq == seq)
>                                                 return 0;
> -                                       else
> +                                       else if (i < iovlen)
>                                                 goto next;
> +                                       return 0;
>                                 }
>
>                                 if (rtnl->proto != NETLINK_SOCK_DIAG &&

Yes. this solves our problem.
Thanks a lot!
William