netdev - Re: [PATCH] net: make tc-police action MTU behavior match documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR12MB13444A412074D74C54AA5E16DDC60@MWHPR12MB1344.namprd12.prod.outlook.com>
Date:   Thu, 1 Mar 2018 00:31:17 +0000
From:   Andrew Collins <acollins@...dlepoint.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
CC:     Jamal Hadi Salim <jhs@...atatu.com>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: make tc-police action MTU behavior match
 documentation

From: Cong Wang <xiyou.wangcong@...il.com>
> If this is just an iproute2 issue, please fix it there rather in kernel.

I'm fine with fixing this as a documentation issue (fix being change man page, MTU "Defaults to unlimited" to "Defaults to 2047").

Note however this does mean that tc-police will keep its (IMO) rather surprising default behavior of dropping coalesced
packets on a GRO enabled interface.

As mentioned in the commit message, segmenting GRO-ed skbs is a better solution long term, do you have any suggestions
for how an action might segment an skb similar to the way tc-tbf does?  I didn't see an obvious method, since qdiscs have
the advantage of an underlying queue whereas actions don't, but perhaps I missed something obvious.