netdev - Re: [PATCH v2 net-next 01/10] net/ipv4: Pass net to fib_multipath_hash instead of fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Mar 2018 15:12:59 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        tom@...bertland.com
Subject: Re: [PATCH v2 net-next 01/10] net/ipv4: Pass net to
 fib_multipath_hash instead of fib_info

On Thu, Mar 01, 2018 at 07:29:41PM -0800, David Ahern wrote:
> fib_multipath_hash only needs net struct to check a sysctl. Make it
> clear by passing net instead of fib_info. In the need this allows
> alignment between the ipv4 and ipv6 versions.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  include/net/ip_fib.h     | 5 +++--
>  net/ipv4/fib_semantics.c | 2 +-
>  net/ipv4/route.c         | 9 +++++----
>  3 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
> index 8812582a94d5..1c4219e88726 100644
> --- a/include/net/ip_fib.h
> +++ b/include/net/ip_fib.h
> @@ -395,8 +395,9 @@ int fib_sync_down_addr(struct net_device *dev, __be32 local);
>  int fib_sync_up(struct net_device *dev, unsigned int nh_flags);
>  
>  #ifdef CONFIG_IP_ROUTE_MULTIPATH
> -int fib_multipath_hash(const struct fib_info *fi, const struct flowi4 *fl4,
> -		       const struct sk_buff *skb, struct flow_keys *flkeys);
> +int fib_multipath_hash(const struct net *net, const struct fib_info *fi,
> +		       const struct flowi4 *fl4, const struct sk_buff *skb,
> +		       struct flow_keys *flkeys);

Why did you keep the fib info?

>  #endif
>  void fib_select_multipath(struct fib_result *res, int hash);
>  void fib_select_path(struct net *net, struct fib_result *res,