netdev - Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Mar 2018 08:33:22 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        tom@...bertland.com
Subject: Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow
 functions

On 3/2/18 7:09 AM, Ido Schimmel wrote:
>> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
>> index 559db9ea8d86..d29f09bc5ff9 100644
>> --- a/net/core/flow_dissector.c
>> +++ b/net/core/flow_dissector.c
>> @@ -1341,22 +1341,6 @@ __u32 __get_hash_from_flowi6(const struct flowi6 *fl6, struct flow_keys *keys)
>>  }
>>  EXPORT_SYMBOL(__get_hash_from_flowi6);
>>  
>> -__u32 __get_hash_from_flowi4(const struct flowi4 *fl4, struct flow_keys *keys)
> 
> Need to remove the declaration from include/net/flow.h

good catch. I'll add to v3.