netdev - Re: [PATCH v3 net-next 02/10] net: Align ip_multipath_l3_keys and ip6_multipath_l3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52e8e15f-9959-8b6c-4346-a37f22276b7d@cumulusnetworks.com>
Date:   Fri, 2 Mar 2018 19:44:11 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     idosch@...sch.org, davem@...emloft.net, roopa@...ulusnetworks.com,
        tom@...bertland.com
Subject: Re: [PATCH v3 net-next 02/10] net: Align ip_multipath_l3_keys and
 ip6_multipath_l3_keys

On 02/03/18 18:32, David Ahern wrote:
> Symmetry is good and allows easy comparison that ipv4 and ipv6 are
> doing the same thing. To that end, change ip_multipath_l3_keys to
> set addresses at the end after the icmp compares, and move the
> initialization of ipv6 flow keys to rt6_multipath_hash.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  net/ipv4/route.c | 20 +++++++++++---------
>  net/ipv6/route.c |  4 ++--
>  2 files changed, 13 insertions(+), 11 deletions(-)
>

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>