netdev - Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04e6981c-bb8d-0af9-5fe3-b9a7f7def3f5@intel.com>
Date:   Fri, 2 Mar 2018 11:52:27 -0800
From:   "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>,
        Alexander Duyck <alexander.duyck@...il.com>
Cc:     Jiri Pirko <jiri@...nulli.us>,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, virtio-dev@...ts.oasis-open.org,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Duyck, Alexander H" <alexander.h.duyck@...el.com>,
        Jakub Kicinski <kubakici@...pl>
Subject: Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when
 available



On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote:
> On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote:
>> The design limits things to a 1:1 relationship since we just have the
>> child and backup pointers, but I don't think I am seeing exception
>> handling to prevent us from overwriting the child pointers so there
>> may be a leak there.
>>
>> Thanks.
>>
>> - Alex
> In fact maintaining a list in that case would be nicer, and
> just use an arbitrary one.
> E.g. one can see how a user wanting to swap device 1 for device 2
> might first add device 2 with same MAC then drop device 1.

It should be possible to swap VF1 with VF2 by
- enabling virtio link
- unplugging VF1
- plugging VF2
- disabling virtio link