netdev - Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip proto, sport and dport attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1519957086.11375.6.camel@gmail.com>
Date:   Thu, 01 Mar 2018 18:18:06 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] fib_rules: FRA_GENERIC_POLICY updates for ip
 proto, sport and dport attrs

On Thu, 2018-03-01 at 17:55 -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Fixes: bfff4862653b ("net: fib_rules: support for match on ip_proto, sport and dport")
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  include/net/fib_rules.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
> index 6dd0a00..1c9e17c 100644
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -112,7 +112,11 @@ struct fib_rule_notifier_info {
>  	[FRA_GOTO]	= { .type = NLA_U32 }, \
>  	[FRA_L3MDEV]	= { .type = NLA_U8 }, \
>  	[FRA_UID_RANGE]	= { .len = sizeof(struct fib_rule_uid_range) }, \
> -	[FRA_PROTOCOL]  = { .type = NLA_U8 }
> +	[FRA_PROTOCOL]  = { .type = NLA_U8 }, \
> +	[FRA_IP_PROTO]  = { .type = NLA_U8 }, \
> +	[FRA_SPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }, \
> +	[FRA_DPORT_RANGE] = { .len = sizeof(struct fib_rule_port_range) }
> +

Thanks Roopa !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>