[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180302025143.vsymizpadsyx3ldp@ast-mbp.dhcp.thefacebook.com>
Date: Thu, 1 Mar 2018 18:51:44 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc: daniel@...earbox.net, netdev@...r.kernel.org,
oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next v2 0/8] tools: bpftool: visualization support
for eBPF program
On Thu, Mar 01, 2018 at 06:01:15PM -0800, Jakub Kicinski wrote:
> Jiong says:
>
> This patch set is an application of CFG information on eBPF program
> visualization. It presents some initial code for building CFG information
> from eBPF instruction sequences.
>
> After we get eBPF program bytecode, we do sub-program detection and
> basic-block partition. These information then are visualized into DOT
> graph.
>
> The user could use any DOT graphic tools (xdot, graphviz etc) to view it.
>
> For example:
>
> bpftool prog dump xlated id 2 visual &>output.dot
>
> [xdot | dotty] output.dot
> dot -Tpng -o output.png
I think generated .png even for simple and short programs isn't readable.
May be some fancy visualizer can help, but I like the cfg parser a lot.
May be you can show jumps and cfg the way perf does it in text with arrows
then it will be much more usable for text only folks like me.
Applied to bpf-next, Thanks everyone.
Powered by blists - more mailing lists