netdev - Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60388182-c6fd-6583-e37b-089b004a3ff9@gmail.com>
Date:   Fri, 2 Mar 2018 09:57:52 +0200
From:   Serhey Popovych <serhe.popovych@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, thomas.de_schampheleire@...ia.com
Subject: Re: [PATCH iproute2 2/3] ss: Fix build with old libc headers without
 AF_VSOCK

Stephen Hemminger wrote:
> On Tue, 27 Feb 2018 14:06:51 +0200
> Serhey Popovych <serhe.popovych@...il.com> wrote:
> 
>> diff --git a/include/compat/libc/bits/socket.h b/include/compat/libc/bits/socket.h
>> new file mode 100644
>> index 0000000..25ef0d5
>> --- /dev/null
>> +++ b/include/compat/libc/bits/socket.h
>> @@ -0,0 +1,15 @@
>> +#ifndef _IP_COMPAT_BITS_SOCKET_H
>> +#define _IP_COMPAT_BITS_SOCKET_H
>> +
>> +#include_next <bits/socket.h>
>> +
>> +#ifndef AF_VSOCK
>> +#define PF_VSOCK	40
>> +#define AF_VSOCK	PF_VSOCK
>> +#undef PF_MAX
>> +#undef AF_MAX
>> +#define PF_MAX		41
>> +#define AF_MAX		PF_MAX
>> +#endif /* AF_VSOCK */
>> +
>> +#endif /* _IP_COMPAT_BITS_SOCKET_H */
> 
> It makes more sense to change ss.c to ifdef out the code related to AF_VSOCK
> if it is not defined.  Rather than asking for unknown address family.
> 

Yes, I did this as v0 before sending series. But now I'm thinking that
single place for all compat stuff would ease tracking of changes.



Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)