netdev - Re: [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04bf951c-979a-567a-cabb-624152db4756@mellanox.com>
Date:   Sun, 4 Mar 2018 15:27:50 +0200
From:   Paul Blakey <paulb@...lanox.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     paulb@...lanox.com, Thomas Graf <tgraf@...g.ch>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Yevgeny Kliteynik <kliteyn@...lanox.com>,
        Roi Dayan <roid@...lanox.com>,
        Shahar Klein <shahark@...lanox.com>,
        Mark Bloch <markb@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Matan Barak <matanb@...lanox.com>
Subject: Re: [PATCH net 1/2] rhashtable: Fix rhltable duplicates insertion



On 04/03/2018 14:57, Herbert Xu wrote:
> On Sun, Mar 04, 2018 at 02:34:26PM +0200, Paul Blakey wrote:
>> When inserting duplicate objects (those with the same key),
>> current rhashtable implementation messes up the chain pointers by
>> updating the bucket pointer instead of prev next pointer to the
>> newly inserted node. This causes missing elements on removal and
>> travesal.
>>
>> Fix that by properly updating pprev pointer to point to
>> the correct rhash_head next pointer.
>>
>> Fixes: ca26893f05e8 ('rhashtable: Add rhlist interface')
>> Signed-off-by: Paul Blakey <paulb@...lanox.com>
> 
> Nack.  You must not insert objects with the same key through
> rhashtable.  The reason is that we cannot reliably fetch all
> of the objects with the same key during a resize.
> 
> If you need duplicate objects, you should use rhlist.
> 
> Cheers,
> 


Hi, I meant the rhlist interface here, sent  v2.
Thanks,
Paul.