netdev - Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180304153123.GA19623@lunn.ch>
Date:   Sun, 4 Mar 2018 16:31:23 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alayev Michael <malayev@....co.il>
Cc:     "'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
        Dror Alon <adror@....co.il>, Efter Yoram <yefter@....co.il>
Subject: Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

Hi Michael

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000b000 0x1000>; */
> /*                           clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 switch0: switch@0 {
>                                                 compatible = "marvell,mv88e6352";

Please use marvell,mv88e6085. That is what the 6352 is compatible
with.

It would also be good to sort out your mixup between tabs and spaces.

>                 mdio {
>                                 compatible = "cdns,macb-mdio";
> /*                           reg = <0xe000c000 0x1000>; */
> /*                           clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; */
> /*                           clock-names = "pclk", "hclk", "tx_clk"; */
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
>                                 status = "okay";
>                                 ethernet_phy: ethernet-phy@0 {
>                                                 compatible = "marvell,mv88e1510";
>                                                 device_type = "ethernet-phy";
>                                                 reg = <0>;
>                                 };

PHYs don't have compatible strings. It is not needed, you can read the
vendor and model from its registers.

       Andrew