netdev - Re: [PATCH 2/2] net: usb: asix88179

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 04 Mar 2018 13:32:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     akurz@...la.de
Cc:     afd@...com, linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        freddy@...x.com.tw
Subject: Re: [PATCH 2/2] net: usb: asix88179_178a: de-duplicate code

From: Alexander Kurz <akurz@...la.de>
Date: Wed, 28 Feb 2018 21:27:39 +0000

> -static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf)
> +static int ax88179_link_bind_or_reset(struct usbnet *dev, int do_reset)

"do_reset" is a boolean, therefore please use type 'bool' and true/false.

Thank you.