netdev - Re: [PATCH net] tc-testing: skbmod: fix match value of ethertype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180304.183916.758241345278727946.davem@davemloft.net>
Date:   Sun, 04 Mar 2018 18:39:16 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     lucasb@...atatu.com, netdev@...r.kernel.org, jhs@...atatu.com
Subject: Re: [PATCH net] tc-testing: skbmod: fix match value of ethertype

From: Davide Caratti <dcaratti@...hat.com>
Date: Fri,  2 Mar 2018 14:44:39 +0100

> iproute2 print_skbmod() prints the configured ethertype using format 0x%X:
> therefore, test 9aa8 systematically fails, because it configures action #4
> using ethertype 0x0031, and expects 0x0031 when it reads it back. Changing
> the expected value to 0x31 lets the test result 'not ok' become 'ok'.
> 
> tested with:
>  # ./tdc.py -e 9aa8
>  Test 9aa8: Get a single skbmod action from a list
>  All test results:
> 
>  1..1
>  ok 1 9aa8 Get a single skbmod action from a list
> 
> Fixes: cf797ac49b94 ("tc-testing: Add test cases for police and skbmod")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied, thanks Davide.