netdev - Re: [PATCH net-next 2/5] net sched actions: add new tc_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180305.100048.1284648153742420410.davem@davemloft.net>
Date:   Mon, 05 Mar 2018 10:00:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mrv@...atatu.com
Cc:     netdev@...r.kernel.org, kernel@...atatu.com, jhs@...atatu.com,
        jiri@...nulli.us, xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next 2/5] net sched actions: add new tc_action_ops
 callback

From: Roman Mashak <mrv@...atatu.com>
Date: Fri,  2 Mar 2018 17:01:40 -0500

> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
> index acac92a..6f3307f 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -136,6 +136,14 @@ static size_t tcf_action_full_attrs_size(size_t sz)
>  		+ sz;
>  }
>  
> +static size_t tcf_action_fill_size(const struct tc_action *act)
> +{
> +	if (act->ops->get_fill_size)
> +		return act->ops->get_fill_size(act) +
> +			tcf_action_shared_attrs_size(act);
> +	return 0;
> +}
> +

Again, a static functions with no users generates compiler warnings.