netdev - Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Mar 2018 17:02:01 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     kbuild-all@...org,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings

On Tue, Mar 06, 2018 at 11:54:07PM +0800, kbuild test robot wrote:
> From: Fengguang Wu <fengguang.wu@...el.com>
> 
> drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in function 'mv88e6352_port_has_serdes' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: eb755c3f6b7d ("net: dsa: mv88e6xxx: Add helper to determining if port has SERDES")
> CC: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew