netdev - Re: [PATCH iproute2 net-next v2] iprule: support for ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <458a21cf-e11e-d4bd-3a82-3aa8ec95652c@gmail.com>
Date:   Tue, 6 Mar 2018 09:18:14 -0700
From:   David Ahern <dsahern@...il.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 net-next v2] iprule: support for ip_proto, sport
 and dport match options

On 3/5/18 11:22 AM, Roopa Prabhu wrote:

> diff --git a/ip/iprule.c b/ip/iprule.c
> index 6fdc9b5..a6a16e6 100644
> --- a/ip/iprule.c
> +++ b/ip/iprule.c
> @@ -45,7 +45,10 @@ static void usage(void)
>  		"       ip rule [ list [ SELECTOR ]]\n"
>  		"SELECTOR := [ not ] [ from PREFIX ] [ to PREFIX ] [ tos TOS ] [ fwmark FWMARK[/MASK] ]\n"
>  		"            [ iif STRING ] [ oif STRING ] [ pref NUMBER ] [ l3mdev ]\n"
> -		"            [ uidrange NUMBER-NUMBER ]\n"
> +		"            [ uidrange NUMBER-NUMBER ]"
> +		"            [ ip_proto [tcp | udp | sctp] ]"
> +		"            [ sport [ NUMBER | NUMBER-NUMBER ]"
> +		"            [ dport [ NUMBER | NUMBER-NUMBER ] ]\n"
>  		"ACTION := [ table TABLE_ID ]\n"
>  		"          [ protocol PROTO ]\n"
>  		"          [ nat ADDRESS ]\n"

missing newlines at the end of uidrange, ip_proto and sport lines; makes
the help impossible to read