netdev - Re: [PATCH iproute2-next 4/7] ip: add json support to ntable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e179e7fd-21a8-53e4-6245-3bc2e60527fe@gmail.com>
Date:   Tue, 6 Mar 2018 09:53:41 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH iproute2-next 4/7] ip: add json support to ntable

On 3/5/18 8:04 PM, Stephen Hemminger wrote:
> @@ -338,274 +339,308 @@ static const char *ntable_strtime_delta(__u32 msec)
>  	return str;
>  }
>  
> -static int print_ntable(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
> +static void print_ndtconfig(const struct ndt_config *ndtc)
>  {
> -	FILE *fp = (FILE *)arg;
> -	struct ndtmsg *ndtm = NLMSG_DATA(n);
> -	int len = n->nlmsg_len;
> -	struct rtattr *tb[NDTA_MAX+1];
> -	struct rtattr *tpb[NDTPA_MAX+1];
> -	int ret;
>  
> -	if (n->nlmsg_type != RTM_NEWNEIGHTBL) {
> -		fprintf(stderr, "Not NEIGHTBL: %08x %08x %08x\n",
> -			n->nlmsg_len, n->nlmsg_type, n->nlmsg_flags);
> -		return 0;
> -	}
> -	len -= NLMSG_LENGTH(sizeof(*ndtm));
> -	if (len < 0) {
> -		fprintf(stderr, "BUG: wrong nlmsg len %d\n", len);
> -		return -1;
> -	}
> +	print_uint(PRINT_ANY, "key_length",
> +		     "    config key_len %u ", ndtc->ndtc_key_len);
> +	print_uint(PRINT_ANY, "entry_size",
> +		     "entry_size %u ", ndtc->ndtc_entry_size);

this one has a number of places where the second line is misaligned.