netdev - Re: [PATCH net-next] net: Only honor ifindex in IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180306.164137.1449749449273628774.davem@davemloft.net>
Date:   Tue, 06 Mar 2018 16:41:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Only honor ifindex in IP_PKTINFO if non-0

From: David Ahern <dsahern@...il.com>
Date: Tue, 6 Mar 2018 13:52:05 -0700

> On 2/16/18 12:03 PM, David Ahern wrote:
>> Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings
>> if the index is actually set in the message.
>> 
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> ---
>>  net/ipv4/ip_sockglue.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
> 
> Dave: Any chance this can get backported to 4.14 and 4.9 stable
> releases? Right now, net-snmp is dead in the water with VRF because it
> uses IP_PKTINFO to set the source address AND in the process sets the
> ifindex to 0 to allow asymmetric routing (request received on one
> interface and response goes out a different one). This patch allows 'ip
> vrf exec mgmt snmpd' to work.

Ok, I've put this patch into 'net' and will let it soak there, and
also queue it up for a future -stable submission.

Thanks David.