netdev - Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180307145642.GA4109@kroah.com>
Date:   Wed, 7 Mar 2018 06:56:42 -0800
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Oliver Neukum <oliver@...kum.org>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path

On Wed, Mar 07, 2018 at 10:46:57AM +0100, Johan Hovold wrote:
> Drop bogus call to usb_driver_release_interface() from an error path in
> the usbnet bind() callback, which is called during interface probe. At
> this point the interface is not bound and usb_driver_release_interface()
> returns early.
> 
> Also remove the bogus call to clear the interface data, which is owned
> by the usbnet driver and would not even have been set by the time bind()
> is called.
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>