netdev - Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180307.112342.1350862113264771178.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 11:23:42 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     tgraf@...g.ch, herbert@...dor.apana.org.au, netdev@...r.kernel.org,
        kliteyn@...lanox.com, roid@...lanox.com, shahark@...lanox.com,
        markb@...lanox.com, jiri@...lanox.com, ogerlitz@...lanox.com,
        matanb@...lanox.com
Subject: Re: [PATCH net v4 0/2] rhashtable: Fix rhltable duplicates
 insertion

From: Paul Blakey <paulb@...lanox.com>
Date: Wed,  7 Mar 2018 16:00:11 +0200

> On our mlx5 driver fs_core.c, we use the rhltable interface to store
> flow groups. We noticed that sometimes we get a warning that flow group isn't
> found at removal. This rare case was caused when a specific scenario happened,
> insertion of a flow group with a similar match criteria (a duplicate),
> but only where the flow group rhash_head was second (or not first)
> on the relevant rhashtable bucket list.
> 
> The first patch fixes it, and the second one adds a test that show
> it is now working.
> 
> Paul.
> 
> v4 --> v3 changes:
>     * Added Herbert Xu's ack (thanks)
>     * Removed extra commit tags

I already applied v3, sorry.  But I did add Herbert's ACKs.
:-)