netdev - Re: [PATCH V3 net] qed: Free RoCE ILT Memory on rmmod qedr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180307.121726.2198524569867142434.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 12:17:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Michal.Kalderon@...ium.com
Cc:     netdev@...r.kernel.org, dledford@...hat.com, jgg@...lanox.com,
        linux-rdma@...r.kernel.org, Ariel.Elior@...ium.com
Subject: Re: [PATCH V3 net] qed: Free RoCE ILT Memory on rmmod qedr

From: Michal Kalderon <Michal.Kalderon@...ium.com>
Date: Mon, 5 Mar 2018 23:50:46 +0200

> Rdma requires ILT Memory to be allocated for it's QPs.
> Each ILT entry points to a page used by several Rdma QPs.
> To avoid allocating all the memory in advance, the rdma
> implementation dynamically allocates memory as more QPs are
> added, however it does not dynamically free the memory.
> The memory should have been freed on rmmod qedr, but isn't.
> This patch adds the memory freeing on rmmod qedr (currently
> it will be freed with qed is removed).
> 
> An outcome of this bug, is that if qedr is unloaded and loaded
> without unloaded qed, there will be no more RoCE traffic.
> 
> The reason these are related, is that the logic of detecting the
> first QP ever opened is by asking whether ILT memory for RoCE has
> been allocated.
> 
> In addition, this patch modifies freeing of the Task context to
> always use the PROTOCOLID_ROCE and not the protocol passed,
> this is because task context for iWARP and ROCE both use the
> ROCE protocol id, as opposed to the connection context.
> 
> Fixes: dbb799c39717 ("qed: Initialize hardware for new protocols")
> 
> Signed-off-by: Michal Kalderon <Michal.Kalderon@...ium.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...ium.com>

Please do not put an empty line in between a Fixes: tag and the
others.  They are all tags, and should be grouped together.

> ---
> Difference from V2:
> 
> Fixed Broken parenthesis In comment

Applied, thank you.