netdev - Re: [PATCH] net: smsc911x: Fix unload crash when link is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180307.132313.862901353807914148.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 13:23:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jeremy.linton@....com
Cc:     netdev@...r.kernel.org, steve.glendinning@...well.net,
        matt.sealey@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: smsc911x: Fix unload crash when link is up

From: Jeremy Linton <jeremy.linton@....com>
Date: Tue,  6 Mar 2018 09:00:06 -0600

> The smsc911x driver will crash if it is rmmod'ed while the netdev
> is up like:
> 
> Call trace:
 ...
> This is caused by the mdiobus being unregistered/free'd
> and the code in phy_detach() attempting to manipulate mdio
> related structures from unregister_netdev() calling close()
> 
> To fix this, we delay the mdiobus teardown until after
> the netdev is deregistered.
> 
> Reported-by: Matt Sealey <matt.sealey@....com>
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Applied, thanks.