netdev - Re: [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180307.145552.823990283862234485.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 14:55:52 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mrv@...atatu.com
Cc:     netdev@...r.kernel.org, kernel@...atatu.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH v2 net-next 3/4] net sched actions: calculate
 add/delete event message size

From: Roman Mashak <mrv@...atatu.com>
Date: Tue,  6 Mar 2018 16:55:23 -0500

> +static size_t tcf_action_fill_size(const struct tc_action *act)
> +{
> +	if (act->ops->get_fill_size)
> +		return act->ops->get_fill_size(act) +
> +			tcf_action_shared_attrs_size(act);
> +	return 0;
> +}

I don't understand this.

The shared attrs should be considered regardless of whether an action
type specific ->get_fill_size() is implemented.

But instead, you return zero in that case.