netdev - Re: [PATCH net] tcp: purge write queue upon aborting the connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180307.150136.839618086949491431.davem@davemloft.net>
Date:   Wed, 07 Mar 2018 15:01:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     soheil.kdev@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, soheil@...gle.com,
        ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: purge write queue upon aborting the connection

From: Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Date: Tue,  6 Mar 2018 17:15:12 -0500

> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> When the connection is aborted, there is no point in
> keeping the packets on the write queue until the connection
> is closed.
> 
> Similar to a27fd7a8ed38 ('tcp: purge write queue upon RST'),
> this is essential for a correct MSG_ZEROCOPY implementation,
> because userspace cannot call close(fd) before receiving
> zerocopy signals even when the connection is aborted.
> 
> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>

Applied and queued up for -stable, thanks.