netdev - Re: [PATCH bpf] tools: bpftool: fix compilation with older headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dafd0932-30b8-4085-e2ab-3734603d2da9@iogearbox.net>
Date:   Wed, 7 Mar 2018 21:56:35 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jiri Benc <jbenc@...hat.com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH bpf] tools: bpftool: fix compilation with older headers

On 03/06/2018 02:50 PM, Jiri Benc wrote:
> Compilation of bpftool on a distro that lacks eBPF support in the installed
> kernel headers fails with:
> 
> common.c: In function ‘is_bpffs’:
> common.c:96:40: error: ‘BPF_FS_MAGIC’ undeclared (first use in this function)
>   return (unsigned long)st_fs.f_type == BPF_FS_MAGIC;
>                                         ^
> Fix this the same way it is already in tools/lib/bpf/libbpf.c and
> tools/lib/api/fs/fs.c.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied it to bpf tree, thanks Jiri!

If preferred by Arnaldo/Ingo/others we can still pull in magic.h later on in
bpf-next and get rid of the ifdefs, not a big thing either.