netdev - Re: [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tvtrzfqz.fsf@intel.com>
Date:   Wed, 07 Mar 2018 14:24:04 -0800
From:   Vinicius Costa Gomes <vinicius.gomes@...el.com>
To:     Jakub Kicinski <kubakici@...pl>
Cc:     intel-wired-lan@...ts.osuosl.org, jeffrey.t.kirsher@...el.com,
        netdev@...r.kernel.org, jesus.sanchez-palencia@...el.com
Subject: Re: [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters

Hi,

Jakub Kicinski <kubakici@...pl> writes:

> On Tue,  6 Mar 2018 17:29:57 -0800, Vinicius Costa Gomes wrote:
>> This allows filters added by tc-flower and specifying MAC addresses,
>> Ethernet types, and the VLAN priority field, to be offloaded to the
>> controller.
>> 
>> This reuses most of the infrastructure used by ethtool, but clsflower
>> filters are kept in a separated list, so they are invisible to
>> ethtool.
>> 
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
>
> LGTM, thanks!
>
>> +		NL_SET_ERR_MSG(extack,
>
> One nit: consider using NL_SET_ERR_MSG_MOD to prefix the message with
> driver name.

Sure thing. Will send a v4 with this shortly.


Cheers,
--
Vinicius