netdev - Re: [RFC v3 iproute2 3/3] tc: Add support for the TBS Qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180307145319.3e0d4470@xeon-e3>
Date:   Wed, 7 Mar 2018 14:53:19 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [RFC v3 iproute2 3/3] tc: Add support for the TBS Qdisc

On Wed, 7 Mar 2018 14:29:23 -0800
Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com> wrote:

> Hi,
> 
> 
> On 03/06/2018 05:51 PM, Stephen Hemminger wrote:
> > On Tue,  6 Mar 2018 17:16:08 -0800
> > Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com> wrote:
> >   
> >> atic int tbs_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
> >> +{
> >> +	struct rtattr *tb[TCA_TBS_MAX+1];
> >> +	struct tc_tbs_qopt *qopt;
> >> +
> >> +	if (opt == NULL)
> >> +		return 0;
> >> +
> >> +	parse_rtattr_nested(tb, TCA_TBS_MAX, opt);
> >> +
> >> +	if (tb[TCA_TBS_PARMS] == NULL)
> >> +		return -1;
> >> +
> >> +	qopt = RTA_DATA(tb[TCA_TBS_PARMS]);
> >> +	if (RTA_PAYLOAD(tb[TCA_TBS_PARMS])  < sizeof(*qopt))
> >> +		return -1;
> >> +
> >> +	fprintf(f, "clockid ");
> >> +	if (qopt->clockid == CLOCKID_INVALID)
> >> +		fprintf(f, "invalid ");
> >> +	else
> >> +		fprintf(f, "%d ", qopt->clockid);
> >> +
> >> +	fprintf(f, "delta %d ", qopt->delta);
> >> +	fprintf(f, "offload %s ", (qopt->flags & TC_TBS_OFFLOAD_ON) ?
> >> +					"on" : "off");
> >> +	fprintf(f, "sorting %s", (qopt->flags & TC_TBS_SORTING_ON) ?
> >> +					"on" : "off");
> >> +
> >> +	return 0;
> >> +}  
> > 
> > All new print code in iproute2 should support JSON output.
> > Look at other code using json_print.h for simple way to handle this.
> >   
> 
> 
> Fixed, thanks. I'm assuming that only applies to print code from print_qopt()
> implementations. Please let me know if otherwise.
> 

Yes. that is what gets invoked by 'tc qdisc show'.
Not everything is updated, but want to get there soon.