netdev - Re: [PATCH] vhost_net: initialize rx_ring in vhost_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <307d6f9e-e308-9d0b-aaac-f3afa65f1164@gmail.com>
Date:   Thu, 8 Mar 2018 07:15:19 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Alexander Potapenko <glider@...gle.com>, dvyukov@...gle.com,
        jasowang@...hat.com, mst@...hat.com
Cc:     kvm@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] vhost_net: initialize rx_ring in vhost_net_open()



On 03/08/2018 05:37 AM, Alexander Potapenko wrote:
> KMSAN reported a use of uninit memory in vhost_net_buf_unproduce()
> while trying to access n->vqs[VHOST_NET_VQ_TX].rx_ring:
> 
> 
> ==================================================================
> 
> Signed-off-by: Alexander Potapenko <glider@...gle.com>

Please identify bug origin with a Fixes: tag

This will tremendously help stable teams that are struggling with many 
backports these days.

Thanks.

> ---
>   drivers/vhost/net.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 610cba276d47..60f1080bffc7 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -948,6 +948,7 @@ static int vhost_net_open(struct inode *inode, struct file *f)
>   		n->vqs[i].done_idx = 0;
>   		n->vqs[i].vhost_hlen = 0;
>   		n->vqs[i].sock_hlen = 0;
> +		n->vqs[i].rx_ring = NULL;
>   		vhost_net_buf_init(&n->vqs[i].rxq);
>   	}
>   	vhost_dev_init(dev, vqs, VHOST_NET_VQ_MAX);
>