netdev - Re: [PATCH net] macvlan: filter out xfrm feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180308.123310.406604126920910381.davem@davemloft.net>
Date:   Thu, 08 Mar 2018 12:33:10 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     shannon.nelson@...cle.com
Cc:     netdev@...r.kernel.org, steffen.klassert@...unet.com
Subject: Re: [PATCH net] macvlan: filter out xfrm feature flags

From: Shannon Nelson <shannon.nelson@...cle.com>
Date: Tue,  6 Mar 2018 14:57:08 -0800

> This isn't broken for vlans because they use a separate features
> connection (vlan_features) for inheriting features.  This is
> fine, but I don't think trying to add something like this to
> every driver for every new upperdev is a good idea - I think
> the upperdev should try to protect itself.

I think this fix is correct.

But for how many upperdevs are we going to duplicate code like this,
and how many subtle differences and in fact bugs will result from all
of that duplication?

I think we really need something common for these upperdev drivers
to use.  Maybe just a macro defining feature bits to trim in this
situation.

Thanks.