netdev - Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large TX rate limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8596d95b-cbdf-0c1a-d421-eb2630b829dc@gmail.com>
Date:   Thu, 8 Mar 2018 11:16:46 -0700
From:   David Ahern <dsahern@...il.com>
To:     Tariq Toukan <tariqt@...lanox.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH V2 iproute2-next] ip-address: Fix negative prints of large
 TX rate limits

On 3/8/18 9:08 AM, Tariq Toukan wrote:
> TX rate limit fields are unsigned (__u32).
> Use %u and print_uint when printing.
> 
> Tested:
> $ ip link set ens1 vf 1 rate 2294967296
> $ ip link show |grep -iE "vf 1" | grep rate
> 
> before:
> vf 1 MAC 00:00:00:00:00:00, tx rate -2000000000 (Mbps), max_tx_rate -2000000000Mbps, ...
> 
> after:
> vf 1 MAC 00:00:00:00:00:00, tx rate 2294967296 (Mbps), max_tx_rate 2294967296Mbps, ...
> 
> Fixes: 3fd86630876a ("iproute2: rework SR-IOV VF support")
> Fixes: 8c29ae7cc249 ("ip link: Fix crash on older kernels when show VF dev")
> Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
> Fixes: ae7229d5f99e ("ip: Add support for setting and showing SR-IOV virtual funtion link params")
> Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> ---
> 
> v1 -> v2:
> Fixed JSON output (print_uint) as well.
> Updated commit message.
> 

change looks fine to me.

As a bug fix seems like this should go to iproute2-master not -next.