netdev - Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180309.114248.1653162492764195930.davem@davemloft.net>
Date:   Fri, 09 Mar 2018 11:42:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dja@...ens.net
Cc:     netdev@...r.kernel.org, daniel@...earbox.net,
        marcelo.leitner@...il.com
Subject: Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

From: Daniel Axtens <dja@...ens.net>
Date: Fri,  9 Mar 2018 14:06:09 +1100

> As well as the basic conversion, I noticed that a lot of the
> SCTP code checks gso_type without first checking skb_is_gso()
> so I have added that where appropriate.
> 
> Also, document the helper.
> 
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Signed-off-by: Daniel Axtens <dja@...ens.net>

Applied, thank you.

It might be nice to consolidate the TCP tests with a helper
like "skb_is_gso_tcp()", but that's just a tidy up and not
so pressing.