netdev - Re: [PATCH v2 net 1/5] tcp: feed correct number of pkts acked to cc modules also in recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1803092311000.23845@whs-18.cs.helsinki.fi>
Date:   Fri, 9 Mar 2018 23:14:23 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
cc:     Netdev <netdev@...r.kernel.org>, Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v2 net 1/5] tcp: feed correct number of pkts acked to cc
 modules also in recovery

On Fri, 9 Mar 2018, Sergei Shtylyov wrote:

> On 03/09/2018 05:10 PM, Ilpo Järvinen wrote:
> 
> > @@ -3068,8 +3072,11 @@ static int tcp_clean_rtx_queue(struct sock *sk, u32 prior_fack,
> > -			if (!after(scb->end_seq, tp->high_seq))
> > +			if (!after(scb->end_seq, tp->high_seq)) {
> >  				flag |= FLAG_ORIG_SACK_ACKED;
> > +			} else {
> > +				newdata_acked += acked_pcount;
> > +			}
> 
>    Why add {} where they're not needed?

Not for a particular reason (I don't know even myself why I added them 
here as usually I don't add such extra braces).

I'll remove them, thanks.

-- 
 i.