netdev - Re: [PATCH] net: remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Mar 2018 23:24:19 +0100
From:   Laszlo Toth <laszlth@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     laszlth@...il.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: remove VLA usage

On Wed, Mar 07, 2018 at 08:26:14PM -0500, David Miller wrote:
> From: Laszlo Toth <laszlth@...il.com>
> Date: Thu, 8 Mar 2018 01:19:53 +0100
> 
> > Separated snmp_seq_show_tcp_udp() to tcp and udp variants,
> > so the usage of max_t() for the array size can be emitted.
> > 
> > Signed-off-by: Laszlo Toth <laszlth@...il.com>
> 
> But it's a max on a constant value, computed at compile
> time.
> 
> I don't see at all why this is necessary.
> 
> If the compiler can't figure this out, fix it.
> 
> If the compiler warns on this with -Wvla, fix it.
> 
> Because there is no reason to have two separate routines for this.
> 
> Thank you.

Yea, since then they'll fix max* defines, so this is unnecessary.
Let's just ignore it.

Laszlo