netdev - Re: WARNING in __proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddcf91b3-8526-bac5-d2bb-c5a39deeaac1@gmail.com>
Date:   Fri, 9 Mar 2018 15:42:53 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     coreteam@...filter.org, David Miller <davem@...emloft.net>,
        Florian Westphal <fw@...len.de>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        netfilter-devel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: WARNING in __proc_create



On 03/09/2018 03:32 PM, Cong Wang wrote:
> On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>>
>>
>> On 03/09/2018 03:05 PM, Cong Wang wrote:
>>>
>>>
>>> BTW, the warning itself is all about empty names, so perhaps
>>> it's better to fix them separately.
>>
>>
>> Huh ? You want more syzbot reports ? I do not.
> 
> I always prefer one patch to fix one problem, and, as I already said,
> checking "." and ".." is probably not as trivial as checking empty.
> 
> This why I believe 2 (or more) patches here are better than 1 single
> patch.
> 
> BTW, I don't have any patch, it is so trivial that I don't want to spend
> my time on it.

The trivial patch has been sent, and Florian gave a (very good) feedback.

Then Pablo offered to write a complete patch.

They both had more pressing issues, and quite frankly I also had more 
pressing issues.

I doubt that sending again the simple fix will be accepted by netfilter 
maintainers.