netdev - Re: [PATCH net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180308.214838.1192721514236112770.davem@davemloft.net>
Date:   Thu, 08 Mar 2018 21:48:38 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        veerasenareddy.burru@...ium.com
Subject: Re: [PATCH net-next] liquidio: fix ndo_change_mtu to always return
 correct status to the caller

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Wed, 7 Mar 2018 22:36:46 -0800

> +	/* command is successful, change the MTU. */
> +	netif_info(lio, probe, lio->netdev, "MTU changed from %d to %d\n",
> +		   netdev->mtu, new_mtu);

Please do not do this, this log message is excessive.

The success return of the MTU change is enough of an indicator
for the user.