netdev - Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daeabe57-0f02-0d2a-2f4c-5256ded71b1b@iogearbox.net>
Date:   Fri, 9 Mar 2018 10:29:00 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jiri Benc <jbenc@...hat.com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next 0/7] tools: bpf: standardize make

On 03/08/2018 11:00 PM, Jiri Benc wrote:
> Currently, 'make bpf' in the tools/ directory does not provide the standard
> quiet output except for bpftool (which is however listed with a wrong
> directory). Worse, it does not respect the build output directory.
> 
> The 'make bpf_install' does not work as one would expect, either. It
> installs unconditionally to /usr/bin without respecting DESTDIR and prefix.
> 
> This patchset improves that behavior.
> 
> Jiri Benc (7):
>   tools: bpftool: silence 'missing initializer' warnings
>   tools: bpf: respect output directory during build
>   tools: bpf: consistent make bpf_install
>   tools: bpf: make install should build first
>   tools: bpf: call descend in Makefile
>   tools: bpf: respect quiet/verbose build
>   tools: bpf: silence make by not deleting intermediate file
> 
>  tools/bpf/Makefile         | 74 +++++++++++++++++++++++++++++++---------------
>  tools/bpf/bpftool/Makefile |  2 +-
>  2 files changed, 51 insertions(+), 25 deletions(-)

Looks good to me as well, applied to bpf-next, thanks Jiri!